Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tsk-180-refactor-file-repository #15

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Conversation

alebg
Copy link
Contributor

@alebg alebg commented Aug 6, 2024

  • TODO: not working on DummyUploadComponent because of a React error catched in the browser console (tested with websat and KP running side by side)

@alebg alebg requested a review from maany August 6, 2024 23:34
- TODO: not working on DummyUploadComponent because of a React error catched in the browser console (tested with websat and KP running side by side)
@maany
Copy link
Contributor

maany commented Aug 7, 2024

Note to Self

Potential solution:

  1. rename the client folder to react in lib/infrastructure
  2. controllers, gateways, presenters should be react hooks.
    ( React Hooks can call other React Hooks)
    This part of the infrastructure is bound to react.

@maany
Copy link
Contributor

maany commented Aug 7, 2024

nvm, found a better way

@maany maany merged commit d445420 into main Aug 9, 2024
4 checks passed
@maany maany deleted the tsk-180-refactor-file-repository branch August 9, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants