Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS middleware to dev servers #127

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

maany
Copy link
Collaborator

@maany maany commented Aug 8, 2024

Adds CORS middleware to dev servers.
This allows testing against websat planckster without having CORS errors for requests originating from the browser

@maany maany added the bug Something isn't working label Aug 8, 2024
@maany maany added this to the 2.0.0 milestone Aug 8, 2024
@maany maany self-assigned this Aug 8, 2024
@maany
Copy link
Collaborator Author

maany commented Aug 8, 2024

@ydamit I guess I need an approval in order to merge this :) ( branch protection)

Copy link
Collaborator

@ydamit ydamit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me!

@maany maany merged commit 1b6af14 into dream-aim-deliver:main Aug 9, 2024
2 checks passed
@maany maany deleted the cors branch August 9, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants