Clear stream cursor for deleted queries #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruokun-niu
approved these changes
Oct 16, 2024
agentofreality
approved these changes
Oct 18, 2024
danielgerlag
force-pushed
the
deleted-query-cursor
branch
from
6214198 to
b48fe64
Compare
danielgerlag
force-pushed
the
deleted-query-cursor
branch
from
b48fe64 to
6093ffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a query is deleted, the cursor for the query container stream is not removed, so when another query with the same name is created, it assumes the old cursor from the previous query. This PR deletes the cursor when the query is deleted.
Type of change