-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated quick-test script on github #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any old smoke test files that need to be deleted from the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, the source, query, and reaction should be deleted in reverse dependency order, although this is not going to matter right now, it will break when we do introduce dependency checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will reverse the order
@@ -0,0 +1,100 @@ | |||
echo Setting up Postgres... | |||
|
|||
helm repo add bitnami https://charts.bitnami.com/bitnami 1>/dev/null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the comment in the PR about moving from helm to kubectl to setup db?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, this file was supposed to be deleted but was accidentally checked-in. The actual smoke test should be the 'smoke-test.sh' file
Currently we dont have any old smoke test files in the Github repos. We can delete the ones that are stored in our storage blob once this PR gets merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets:
- put this in a folder called dev-tools/testing/quick-test-environment
- change file names from 'smoke-test-' to 'quick-test-environment-'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice there is no cleanup for PowerShell
I'll also update any occurences of "Smoke Test" to "Quick Test" so that it is consistent with the samples in the doc site |
Description
kubectl
to setup a database instead of usinghelm
When this gets merged into main, the smoke-test can be invoked by using the following commands
MacOS:
Windows powershell
For now, if you want to test the script, run the following command (the file is hosted on a branch on my personal fork)
curl -fL https://raw.githubusercontent.com/ruokun-niu/drasi-platform/smoke-test-test/dev-tools/smoke-tests/smoke-test.sh | /bin/bash -s smoke
Logs from a successful bash run: https://gist.github.com/ruokun-niu/605eae11b9ec034285a2630f20521ea6
Logs from a successful powershell run: https://gist.github.com/ruokun-niu/724f1debfd276560356151a0295843a5
Type of change
Fixes: #issue_number