Updated CLI installation script #69
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if ((Get-ExecutionPolicy) -gt 'RemoteSigned' -or (Get-ExecutionPolicy) -eq 'ByPass') { | ||
| Write-Output "PowerShell requires an execution policy of 'RemoteSigned'." | ||
| Write-Output "To make this change please run:" | ||
| Write-Output "'Set-ExecutionPolicy RemoteSigned -scope CurrentUser'" |
Check warning
Code scanning / devskim
The Set-ExecutionPolicy cmdlet has been used to dynamically change the permissions available to PowerShell. Warning
| } | ||
|
|
||
| # Change security protocol to support TLS 1.2 / 1.1 / 1.0 - old powershell uses TLS 1.0 as a default protocol | ||
| [Net.ServicePointManager]::SecurityProtocol = "tls12, tls11, tls" |
Check notice
Code scanning / devskim
Generic: Hard-coded SSL/TLS Protocol Note
| } | ||
|
|
||
| # Change security protocol to support TLS 1.2 / 1.1 / 1.0 - old powershell uses TLS 1.0 as a default protocol | ||
| [Net.ServicePointManager]::SecurityProtocol = "tls12, tls11, tls" |
Check notice
Code scanning / devskim
Generic: Hard-coded SSL/TLS Protocol Note
| @@ -0,0 +1,150 @@ | |||
| param ( | |||
| [string]$Version, | |||
| [string]$DrasiRoot = "$env:LOCALAPPDATA\drasi" | |||
There was a problem hiding this comment.
The Makefile install puts it in $env:ProgramFiles\drasi
cli/installers/install-drasi-cli.ps1
Outdated
| $release = $Releases | Where-Object { $_.tag_name -notlike "*rc*" } | Select-Object -First 1 | ||
| } | ||
| else { | ||
| $release = $Releases | Where-Object { $_.tag_name -eq "v$Version" } | Select-Object -First 1 |
There was a problem hiding this comment.
Does this always return the latest release?
There was a problem hiding this comment.
Yeah, I think the github api lists releases with the most recent release at the top. This will fetch the first (most recent) release
cli/installers/install-drasi-cli.ps1
Outdated
| } | ||
|
|
||
| # Version string | ||
| Write-Output "drasi CLI version: $(&$DrasiCliFilePath version -o json | ConvertFrom-JSON | Select-Object -ExpandProperty version)" |
There was a problem hiding this comment.
I'm not sure this works drasi?
There was a problem hiding this comment.
Oh right. Maybe we can just output the release tag/version that was used in the download
Description
Updated the CLI installation script to download from Github instead of Azure storage blob
also enabled the ability to download a specific version
TODO:
test with windows (will do this after I get back home today so that I can use my windows machine 😄 )
test in dev container
Type of change
Fixes: #issue_number