Replace dapr packages to use the official crate instead of personal forks #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oject/drasi-platform into drasi-project-dapr-fork * 'drasi-project-dapr-fork' of https://github.com/drasi-project/drasi-platform: remove sha1 (#36) windows dev support (#40) release docs (#32)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Introduce delay so that dapr grpc port is assigned before app tries to connect | ||
| std::thread::sleep(std::time::Duration::new(3, 0)); | ||
|
|
||
| let dapr_client = dapr::Client::<dapr::client::TonicClient>::connect(dapr_addr) | ||
| let addr = "https://127.0.0.1".to_string(); |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
| let mongo_uri = std::env::var("MONGO_URI").unwrap_or("mongodb://rg-mongo:27017".to_string()); | ||
| let mongo_db = std::env::var("MONGO_DB").unwrap_or("api".to_string()); | ||
| let redis_url = std::env::var("REDIS_URL").unwrap_or("redis://rg-redis:6379".to_string()); | ||
|
|
||
| // Introduce delay so that dapr grpc port is assigned before app tries to connect | ||
| std::thread::sleep(std::time::Duration::new(5, 0)); | ||
|
|
||
| let dapr_client = dapr::Client::<dapr::client::TonicClient>::connect(dapr_addr) | ||
| let addr = "https://127.0.0.1".to_string(); |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
| @@ -86,9 +83,10 @@ | |||
| pubsub, | |||
| )); | |||
|
|
|||
| let dapr_client = dapr::Client::<dapr::client::TonicClient>::connect(dapr_addr) | |||
| let addr = "https://127.0.0.1".to_string(); | |||
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling. Note
agentofreality
approved these changes
Sep 11, 2024
ruokun-niu
force-pushed
the
drasi-project-dapr-fork
branch
from
3937026 to
b6fa80a
Compare
danielgerlag
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As our previous contributions to the Dapr Rust SDK repo have been merged and a new version was released, we should replace the source of the
daprpackage in ourCargo.tomlfiles to use the official crate.Currently, we are setting the version to be fixed at
0.15.1. We also had to updateaxumto the latest version to ensure that everything is compatible (which includes some code changes, seeview-svc).Type of change
Fixes: #issue_number