CLI Error messages & progress feedback #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruokun-niu
reviewed
Sep 5, 2024
| import ( | ||
| "fmt" | ||
| "github.com/charmbracelet/bubbles/spinner" | ||
| tea "github.com/charmbracelet/bubbletea" |
ruokun-niu
reviewed
Sep 5, 2024
| @@ -20,6 +20,8 @@ spec: | |||
| apiVersion: apps/v1 | |||
| kind: StatefulSet | |||
| metadata: | |||
| labels: | |||
| app: rg-redis | |||
There was a problem hiding this comment.
Should we use drasi-redis instead?
There was a problem hiding this comment.
This label was missing, which was causing the installer to wait and eventually time out for redis.
We'll have to deal with this when we resolve conflicts with #42
ruokun-niu
previously approved these changes
Sep 5, 2024
agentofreality
approved these changes
Sep 9, 2024
danielgerlag
force-pushed
the
cli-error-msgs
branch
2 times, most recently
from
b69ea22 to
0781576
Compare
ruokun-niu
approved these changes
Sep 11, 2024
danielgerlag
force-pushed
the
cli-error-msgs
branch
from
0781576 to
d439ca3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved error reporting and progress feedback for install/apply/delete commands.
Type of change