Review Change Router #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agentofreality
approved these changes
Sep 9, 2024
| None => { | ||
| return StatusCode::BAD_REQUEST; | ||
| return (StatusCode::BAD_REQUEST, | ||
| Json(json!({"error": "Missing traceparent header"}))); |
There was a problem hiding this comment.
I'm not sure if we should fail the whole request if the trace header is missing or invalid.
| @@ -355,6 +478,8 @@ async fn process_changes( | |||
| } | |||
| } | |||
| } | |||
| } else { | |||
| return Err(Box::<dyn std::error::Error>::from("Expected changes to be an array")); | |||
There was a problem hiding this comment.
I would put the error check in the beginning of the function and exit early... It's just easier to read that way.
danielgerlag
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Fixes: #issue_number