Initial contribution guide and templates #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danielgerlag
commented
Jul 31, 2024
danielgerlag
commented
- Initial contribution guide
- Issue & PR templates
- Makefile builds
Signed-off-by: Daniel Gerlag <daniel@gerlag.ca>
ruokun-niu
reviewed
Aug 1, 2024
| @@ -0,0 +1,98 @@ | |||
| # Contributing Pull Requests | |||
There was a problem hiding this comment.
Should we have a requirement to use git rebase instead of git merge, or vice versa?
There was a problem hiding this comment.
I don't think we have to make that a hard requirement, since we can squash the entire PR into one commit when we merge it anyway.
agentofreality
approved these changes
Aug 5, 2024
Co-authored-by: Agent of Reality <agentx@agentofreality.com>
ruokun-niu
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.