Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a 'repo' condition for workflows in drasi-platform #23

Merged
merged 4 commits into from
Sep 13, 2024
Merged

added a 'repo' condition for workflows in drasi-platform #23

merged 4 commits into from
Sep 13, 2024

Conversation

ruokun-niu
Copy link
Contributor

  • The Devskim, scorecard and publish_artifacts should not be triggered on forked repos
  • For the publish workflow, currently there is no limitation as people might want to publish images from their forked repos. Thoughts?

Copy link
Contributor

@agentofreality agentofreality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand your comment about the 'publish' workflow, lets discuss tomorrow at sync before we merge.

@ruokun-niu
Copy link
Contributor Author

Ohh I might've phrased that weirdly. We currently have a publish workflow that is used to publish images to GHCR. Fo the jobs in that workflow, I did not add any conditions on the repo field.

As a result, users will be able to publish images to their own GHCR when publishing from a forked repo. I am unsure if this is the desired behavior. We can discuss later

@ruokun-niu
Copy link
Contributor Author

Ohh I might've phrased that weirdly. We currently have a publish workflow that is used to publish images to GHCR. Fo the jobs in that workflow, I did not add any conditions on the repo field.

As a result, users will be able to publish images to their own GHCR when publishing from a forked repo. I am unsure if this is the desired behavior. We can discuss later

Also I just noticed that Daniel has modified the publish workflow, so this might not be applicable anymore. Still down for discussing this tomorrow

@ruokun-niu ruokun-niu requested review from danielgerlag and removed request for danielgerlag September 9, 2024 18:53
@ruokun-niu ruokun-niu merged commit d2e7c97 into drasi-project:main Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants