Debezium date format + trustServerCertificate flag #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgerlag
requested review from
amansinghoriginal,
agentofreality and
ruokun-niu
ruokun-niu
approved these changes
Oct 30, 2024
agentofreality
previously requested changes
Nov 4, 2024
There was a problem hiding this comment.
@danielgerlag doesn't this need a license header?
danielgerlag
force-pushed
the
debezium-fixes1
branch
from
5128679 to
60e15d2
Compare
There was a problem hiding this comment.
what changed here?
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
There was a problem hiding this comment.
is there a whitespace change here?
There was a problem hiding this comment.
I'm not sure why the license headers sometimes show a changed. Could be a CR/LF issue.
| @@ -25,6 +25,7 @@ | |||
| import io.debezium.jdbc.JdbcConnection; | |||
| import io.debezium.relational.RelationalDatabaseConnectorConfig; | |||
|
|
|||
| import java.sql.ResultSet; | |||
There was a problem hiding this comment.
where is this used?
amansinghoriginal
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change