-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
veneur-proxy: Add option for GRPC streaming to veneur-global #2
veneur-proxy: Add option for GRPC streaming to veneur-global #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd make sure to run tests; which you can do by running docker build .
Hi @Oscil8. Thanks for taking the time to review this code. I wanted to add a unit test, but it's difficult to test this toggle in isolation. So, I've adapted an existing test and I've looked at the coverage to ensure that the happy path is being hit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I'll get a release cut after you merge
@Oscil8 I can't merge this PR as I don't have write access to this repo 😅 |
Context
I've switched the veneur pipeline in our production clusters to using gRPC in order to address a bug. Unfortunately, in large clusters the batches produced by veneur are significantly larger that the default MaxRecvSize (4MiB) in the gRPC library.
Here's the error message:
This error was easily resolved by enabling gRPC streaming in the veneur DaemonSet (configuration).
After enabling this streaming feature, I discovered that problem had now moved upstream to veneur-proxy. Veneur-proxy was now logging the same error. Unfortunately, gRPC streaming is not configurable within veneur-proxy. So, I've had to add the feature.
We've been running this patch in all of our clusters for the past week.