[Wisp] Blocking io support for SocketChannel and Pipe #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyleeeeeee97
force-pushed
the
master
branch
6 times, most recently
from
59a63dc to
80d1cb7
Compare
yuleil
reviewed
Nov 23, 2020
| import java.nio.channels.SelectableChannel; | ||
| import java.nio.channels.SelectionKey; | ||
| import java.nio.channels.Selector; | ||
| import java.nio.channels.*; |
| import java.nio.channels.NotYetBoundException; | ||
| import java.nio.channels.ServerSocketChannel; | ||
| import java.nio.channels.SocketChannel; | ||
| import java.nio.channels.*; |
joeyleeeeeee97
force-pushed
the
master
branch
from
80d1cb7 to
38d8b94
Compare
yuleil
reviewed
Nov 23, 2020
| @@ -344,6 +344,25 @@ public void getCpuTime(long[] ids, long[] times) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public int poll(SelectableChannel channel, int interestOps, long millsTimeOut) throws IOException { | |||
There was a problem hiding this comment.
- WAE.poll should return polled event count;
- WAE.poll receive NET.* events represent as parameters will be clearer.
- Coroutines are not interrupted when the socket closes. Leave a TODO there
There was a problem hiding this comment.
OK. please have another look.
Close socket is ok here, because we would check isOpen() every time.
joeyleeeeeee97
force-pushed
the
master
branch
3 times, most recently
from
c2ddb40 to
9e76d2c
Compare
joeyleeeeeee97
commented
Nov 23, 2020
| } | ||
| } | ||
|
|
||
| int translateToSelectionKey(int event) { |
There was a problem hiding this comment.
Can't use switch here because Net.POLLIN is not constant.
joeyleeeeeee97
force-pushed
the
master
branch
2 times, most recently
from
6a392db to
1ae35b8
Compare
yuleil
reviewed
Nov 23, 2020
| @@ -25,6 +25,8 @@ | |||
|
|
|||
| package sun.nio.ch; | |||
|
|
|||
| import com.alibaba.wisp.engine.WispEngine; | |||
| } | ||
|
|
||
| @Override | ||
| public int poll(SelectableChannel channel, int interestOps, long millsTimeOut) throws IOException { |
There was a problem hiding this comment.
add JavaDoc to point out it's a Net.* event represent
joeyleeeeeee97
force-pushed
the
master
branch
from
1ae35b8 to
69648f6
Compare
yuleil
reviewed
Nov 24, 2020
| * @return active event count | ||
| * @throws IOException | ||
| */ | ||
| @Override |
There was a problem hiding this comment.
put the java doc above method in the interface
| @@ -25,6 +25,7 @@ | |||
|
|
|||
| package sun.nio.ch; | |||
|
|
|||
|
|
|||
| @@ -278,7 +271,9 @@ public SocketChannel accept() throws IOException { | |||
| if (n < 1) | |||
| return null; | |||
|
|
|||
| IOUtil.configureBlocking(newfd, true); | |||
| if (!WispEngine.transparentWispSwitch()) { | |||
There was a problem hiding this comment.
use configureAsNonBlockingForWisp
| @@ -25,6 +25,7 @@ | |||
|
|
|||
| package sun.nio.ch; | |||
|
|
|||
|
|
|||
| try { | ||
| configureAsNonBlockingForWisp(fd); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Unexpected error at configureAsNonBlockingForWisp", e); |
joeyleeeeeee97
force-pushed
the
master
branch
2 times, most recently
from
a6ef9e1 to
cb6933c
Compare
|
|
joeyleeeeeee97
force-pushed
the
master
branch
from
cb6933c to
07926ed
Compare
yuleil
reviewed
Nov 25, 2020
| @@ -165,6 +175,12 @@ public int read(ByteBuffer dst) throws IOException { | |||
| thread = NativeThread.current(); | |||
| do { | |||
| n = IOUtil.read(fd, dst, -1, nd); | |||
| if (isBlocking() && WispEngine.transparentWispSwitch()) { | |||
There was a problem hiding this comment.
WispEngine.transparentWispSwitch() && isBlocking()
joeyleeeeeee97
force-pushed
the
master
branch
2 times, most recently
from
e210c92 to
4c95f4b
Compare
yuleil
approved these changes
Nov 25, 2020
Summary: Hook blocking entry at pipeChannel and SocketChannel, current WispTask would block itself to wait for next scheduling. Test Plan: jtreg BlockIngIOTest. Reviewed-by: zhengxiaolinX, yuleil Issue: dragonwell-project/dragonwell8#143
joeyleeeeeee97
force-pushed
the
master
branch
from
4c95f4b to
3b3d0cf
Compare
zhengxiaolinX
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Hook blocking entry at pipeChannel and SocketChannel,
current WispTask would block itself to wait for next scheduling.
Test Plan: jtreg BlockIngIOTest.
Reviewed-by: zhengxiaolinX, yuleil
Issue: dragonwell-project/dragonwell8#143