Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nydusify: refactor with converter package #970

Merged
merged 4 commits into from
Dec 26, 2022
Merged

nydusify: refactor with converter package #970

merged 4 commits into from
Dec 26, 2022

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Dec 21, 2022 •
edited
Loading 

Refactor converter workflow using the converter package in
acceld project:

https://github.com/goharbor/acceleration-service/pull/84

This allows nydusify to reuse acceld/snapshotter codes and
to convert layers concurrently, as well as to support the
zran conversion later.

This patch causes nydusify to rely on the containerd daemon
service, we will remove this restriction in the next commit.

Signed-off-by: Yan Song imeoer@linux.alibaba.com

@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@imeoer imeoer force-pushed the refactor-nydusify-2 branch from a4a10ae to 3c252f0 Compare December 22, 2022 06:30
@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

1 similar comment
@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@imeoer imeoer force-pushed the refactor-nydusify-2 branch from ed74cb2 to f4dd803 Compare December 22, 2022 07:23
@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@imeoer imeoer force-pushed the refactor-nydusify-2 branch from f4dd803 to fcf5e8c Compare December 22, 2022 08:05
@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@imeoer imeoer force-pushed the refactor-nydusify-2 branch from fcf5e8c to 3275d7c Compare December 22, 2022 08:11
@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@imeoer imeoer force-pushed the refactor-nydusify-2 branch from 3275d7c to 776645d Compare December 22, 2022 08:18
@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@imeoer imeoer force-pushed the refactor-nydusify-2 branch from 776645d to b86c040 Compare December 22, 2022 10:53
@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@imeoer imeoer force-pushed the refactor-nydusify-2 branch from b86c040 to 07d5424 Compare December 22, 2022 11:50
@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@imeoer imeoer force-pushed the refactor-nydusify-2 branch from 07d5424 to 3aedac4 Compare December 22, 2022 12:18
@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@imeoer imeoer force-pushed the refactor-nydusify-2 branch from 3aedac4 to f24d259 Compare December 23, 2022 02:27
@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@imeoer
nydusify: refactor with converter package
48634b6 
Refactor converter workflow using the converter package in
acceld project:

goharbor/acceleration-service#84

This allows nydusify to reuse acceld/snapshotter codes and
to convert layers concurrently, as well as to support the
zran conversion later.

This patch causes nydusify to rely on the containerd daemon
service, we will remove this restriction in the next commit.

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
@imeoer
nydusify: support chunk dict (refactor)
bd26608 
Recovery chunk dict feature broken by the code refactoring.

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
@imeoer
nydusify: remove containerd client dependence
7dbb428 
Remove containerd client and implement the content.Provider interface
to resolve, pull and push image by self.

This patch allows nydusify do the conversion without a containerd
daemon service.

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
@imeoer
nydusify: fix tests broken by code refactoring
dc83f58 
And remove useless `registry` backend type in cli options.

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
@imeoer imeoer force-pushed the refactor-nydusify-2 branch from f24d259 to dc83f58 Compare December 23, 2022 03:12
@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

1 similar comment
@anolis-bot
Copy link
Collaborator

@imeoer , the title of this PR starts with "WIP" or "[WIP]", so skip testing for now.

@imeoer imeoer changed the title [WIP] nydusify: refactor with converter package nydusify: refactor with converter package Dec 23, 2022
@anolis-bot
Copy link
Collaborator

@imeoer , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/40206

@anolis-bot
Copy link
Collaborator

@imeoer , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus✅ SUCCESS
compile-ctr-remote✅ SUCCESS
compile-nydus-snapshotter✅ SUCCESS
start-nydus-snapshotter-config-containerd✅ SUCCESS
run-container-with-nydus-image✅ SUCCESS

Congratulations, your test job passed!

liubogithub
liubogithub reviewed Dec 24, 2022
View reviewed changes
Copy link
Collaborator

@liubogithub liubogithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we copy containerd.fetch() and containerd.pull()?

@imeoer
Copy link
Collaborator Author

imeoer commented Dec 26, 2022

why do we copy containerd.fetch() and containerd.pull()?

The part of codes is not exported, so we must port it.

@jiangliu jiangliu merged commit f4dd9e1 into dragonflyoss:master Dec 26, 2022
Desiki-high added a commit to Desiki-high/acceleration-service that referenced this pull request Oct 10, 2023
@Desiki-high
fix: remove useless backend-type registry
7ac9ad2 
ref: dragonflyoss/nydus#970

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high added a commit to Desiki-high/acceleration-service that referenced this pull request Oct 10, 2023
@Desiki-high
fix: remove useless backend-type registry
ffa01c1 
ref: dragonflyoss/nydus#970

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high added a commit to Desiki-high/acceleration-service that referenced this pull request Oct 10, 2023
@Desiki-high
fix: remove useless args backend-type etc.
7de99e9 
ref: dragonflyoss/nydus#970

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Desiki-high added a commit to Desiki-high/acceleration-service that referenced this pull request Oct 10, 2023
@Desiki-high
fix: remove useless args backend-type etc.
8c3c3cf 
ref: dragonflyoss/nydus#970

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liubogithub liubogithub liubogithub approved these changes

Assignees
No one assigned
Labels
anolis_test_pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imeoer @anolis-bot @liubogithub @jiangliu