Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve prefetch performance further #633

Merged
merged 3 commits into from
Aug 3, 2022

Conversation

jiangliu
Copy link
Collaborator

@jiangliu jiangliu commented Aug 2, 2022

Improve prefetch performance further, now v5 image performs as better as 1.1.2.

@anolis-bot
Copy link
Collaborator

@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/17074

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus✅ SUCCESS
compile-ctr-remote✅ SUCCESS
compile-nydus-snapshotter✅ SUCCESS
start-nydus-snapshotter-config-containerd✅ SUCCESS
run-container-with-nydus-image✅ SUCCESS

Congratulations, your test job passed!

rafs/src/fs.rs Outdated Show resolved Hide resolved
Split blob prefetch request into small chunks for v6 images.
There's no range based prefetch for v5 now, so disable it.

Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
When prefetch file list and prefetch_all are both enabled, the whole
data may get prefetched twice. Though the second prefetch won't actually
download data from remote, it's still waste.

Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Improve the io request merging algorithm to hunt for more chances
to reduce IO requests.

Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
@anolis-bot
Copy link
Collaborator

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/17209

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus✅ SUCCESS
compile-ctr-remote✅ SUCCESS
compile-nydus-snapshotter✅ SUCCESS
start-nydus-snapshotter-config-containerd✅ SUCCESS
run-container-with-nydus-image✅ SUCCESS

Congratulations, your test job passed!

Copy link
Contributor

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@changweige changweige merged commit 535159e into dragonflyoss:master Aug 3, 2022
@jiangliu jiangliu deleted the prefetch2 branch November 8, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants