Nydusify: support "view" subcommand to view Nydus image #603
Conversation
|
@YushuoEdge , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/13445 |
|
@YushuoEdge , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
YushuoEdge
force-pushed
the
nydusify/view
branch
from
03eab23
to
8915210
Compare
|
@YushuoEdge , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/13446 |
|
@YushuoEdge , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
contrib/nydusify/cmd/nydusify.go
Outdated
|
|
||
| &cli.StringFlag{Name: "mount-path", Value: "./image-fs", Usage: "The Path for the file system to mount on", EnvVars: []string{"MOUNT_PATH"}}, | ||
| &cli.StringFlag{Name: "platform", Value: "linux/" + runtime.GOARCH, Usage: "Let nydusify choose image of specified platform from manifest index. Possible value is `amd64` or `arm64`"}, | ||
| &cli.StringFlag{Name: "work-dir", Value: "./tmp", Usage: "Work directory path for image check, will be cleaned before checking", EnvVars: []string{"WORK_DIR"}}, |
There was a problem hiding this comment.
will be cleaned before viewing
There was a problem hiding this comment.
yes，maybe we should give a hint?
contrib/nydusify/cmd/nydusify.go
Outdated
| &cli.StringFlag{Name: "platform", Value: "linux/" + runtime.GOARCH, Usage: "Let nydusify choose image of specified platform from manifest index. Possible value is `amd64` or `arm64`"}, | ||
| &cli.StringFlag{Name: "work-dir", Value: "./tmp", Usage: "Work directory path for image check, will be cleaned before checking", EnvVars: []string{"WORK_DIR"}}, | ||
| &cli.StringFlag{Name: "nydusd", Value: "nydusd", Usage: "The nydusd binary path, if unset, search in PATH environment", EnvVars: []string{"NYDUSD"}}, | ||
| &cli.StringFlag{Name: "backend-type", Value: "", Usage: "Specify Nydus blob storage backend type, will check file data in Nydus image if specified", EnvVars: []string{"BACKEND_TYPE"}}, |
There was a problem hiding this comment.
will allow viewing file data in Nydus image if specified
There was a problem hiding this comment.
Should we specify a specific backend type here?
| @@ -203,11 +205,14 @@ func (nydusd *Nydusd) Mount() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (nydusd *Nydusd) Umount() error { | |||
| func (nydusd *Nydusd) Umount(mountFlag bool) error { | |||
There was a problem hiding this comment.
Better to use silent bool.
| return errors.Wrap(err, "clean up work directory error") | ||
| } | ||
|
|
||
| if err := os.MkdirAll(filepath.Join(fsViewer.WorkDir, "fs"), 0755); err != nil { |
| func (fsViewer *FsViewer) MountImage() error { | ||
| logrus.Infof("Mounting Nydus image to %s", fsViewer.NydusdConfig.MountPath) | ||
|
|
||
| if err := os.MkdirAll(fsViewer.NydusdConfig.BlobCacheDir, 0755); err != nil { |
| return errors.Wrap(err, "create blob cache directory for Nydusd error") | ||
| } | ||
|
|
||
| if err := os.MkdirAll(fsViewer.NydusdConfig.MountPath, 0755); err != nil { |
|
|
||
| go func() { | ||
| sig := <-sigs | ||
| fmt.Println("Received Signal: ", sig) |
There was a problem hiding this comment.
logrus.Infof("Received Signal: %s", sig) ?
| done <- true | ||
| }() | ||
|
|
||
| fmt.Println("Please send signal SIGINT/SIGTERM to umount the file system") |
contrib/nydusify/cmd/nydusify.go
Outdated
| @@ -397,6 +398,58 @@ func main() { | |||
| return checker.Check(context.Background()) | |||
| }, | |||
| }, | |||
| { | |||
| Name: "view", | |||
There was a problem hiding this comment.
Maybe we can add an alias Aliases: []string{"mount"},.
YushuoEdge
force-pushed
the
nydusify/view
branch
from
8915210
to
7935512
Compare
|
@YushuoEdge , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/15298 |
|
@YushuoEdge , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
Nydusify provides a fsViewer to view the file system in the Nydus image. The fsViewer will pull image's bootstrap according to its url, and it will mount the file system to pointed path. Users can view the file system then. For example, they can ran `$ trivy fs mount-path` to scan the whole image. Signed-off-by: YushuoEdge <y-shuo@sjtu.edu.cn>
YushuoEdge
force-pushed
the
nydusify/view
branch
from
7935512
to
ea5c2e3
Compare
|
@YushuoEdge , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/15299 |
|
@YushuoEdge , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
Nydusify provides a fsViewer to view the file system in the Nydus image.
The fsViewer will pull image's bootstrap according to its url, and it
will mount the file system to pointed path.
Users can view the file system then. For example, they can ran
$ trivy fs mount-pathto scan the whole image.
Signed-off-by: YushuoEdge y-shuo@sjtu.edu.cn