Display detailed error in FsCacheHandler constructor when cachefiles device not ready #596
Conversation
|
@benjaminhuanghuang , a new test job has been submitted. Please wait in patience. |
|
@benjaminhuanghuang , The CI test is completed, please check result:
Sorry, your test job failed. Please get the details in the link. |
||||||||||||
|
@benjaminhuanghuang , your pull request has been updated. A new test job will be submitted. Please wait in patience. |
|
@benjaminhuanghuang , the test job has been submitted. Please wait in patience. |
benjaminhuanghuang
force-pushed
the
bh-FsCacheHandler
branch
from
6b524f8
to
cc122f3
Compare
|
@benjaminhuanghuang , your pull request has been updated, but a test job is already running. A new test job wil be submitted after the current job is finished. |
|
@benjaminhuanghuang , your test job is running now. Please wait in patience. |
|
@benjaminhuanghuang , The CI test is completed, please check result:
Sorry, the current test job result is not valid, because your pull request has been updated, and a new test job will be submitted. |
||||||||||||||||||||||||
src/bin/nydusd/fs_cache.rs
Outdated
| .open(path) | ||
| .map_err(|e| { | ||
| error!( | ||
| "Failed to open cachefiles device {}. {}. Please try `modprobe cachefiles`", |
There was a problem hiding this comment.
"Failed to open cachefiles device {}:" is better. :)
There was a problem hiding this comment.
Yeah, I think modprobe cachefiles is no needed to be seen here, there might be other reasons.
There was a problem hiding this comment.
@hsiangkao You are right. Cachefiles device does not work in my env (Ubuntu 22.04, 5.19.0-rc3+, Virtualbox) after cachefiles enabled. Do you know what are the reasons cause this issue ?
|
/retest |
|
@hsiangkao , the test job has been submitted. Please wait in patience. |
|
@hsiangkao , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
benjaminhuanghuang
force-pushed
the
bh-FsCacheHandler
branch
from
cc122f3
to
294af0f
Compare
|
@benjaminhuanghuang , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/10858 |
…device not ready. Files: fs_cache.rs Signed-off-by: Benjamin Huang <benjaminhuanghuang@gmail.com>
|
@benjaminhuanghuang , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
benjaminhuanghuang
force-pushed
the
bh-FsCacheHandler
branch
from
294af0f
to
d226879
Compare
|
@benjaminhuanghuang , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/10859 |
benjaminhuanghuang
changed the title
|
@benjaminhuanghuang , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/10860 |
benjaminhuanghuang
changed the title
|
@benjaminhuanghuang , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/10861 |
|
@benjaminhuanghuang , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@benjaminhuanghuang , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
@benjaminhuanghuang , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
Display detailed error when construct FsCacheHandler with a nonexistent path
Files: fs_cache.rs
Signed-off-by: Benjamin Huang benjaminhuanghuang@gmail.com