Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nydus-image: fix the prefetch table was out of bounds due to use the wrong index #530

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

zyfjeff
Copy link
Contributor

@zyfjeff zyfjeff commented Jun 24, 2022

At present, the prefetch table of v6 is stored in Node.index, which starts from 1,
and when we get the prefetch table, we mistakenly treat it as an array index

Signed-off-by: zyfjeff zyfjeff@linux.alibaba.com

@yqleng1987
Copy link
Contributor

@zyfjeff , a new test job has been submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@zyfjeff , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅SUCCESS
build-docker-image✅SUCCESS
compile-nydus✅SUCCESS
compile-ctr-remote✅SUCCESS
compile-nydus-snapshotter✅SUCCESS
start-nydus-snapshotter-config-containerd✅SUCCESS
run-container-with-nydus-image✅SUCCESS

Congratulations, your test job passed!

@yqleng1987
Copy link
Contributor

@zyfjeff , your pull request has been updated. A new test job will be submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@zyfjeff , your test job has passed, and no need to test again.

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zyfjeff zyfjeff force-pushed the fix-prefetch-with-empty-dir branch from d9d1db4 to efc015c Compare June 24, 2022 08:49
@yqleng1987
Copy link
Contributor

@zyfjeff , your pull request has been updated. A new test job will be submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@zyfjeff , the test job has been submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@zyfjeff , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅SUCCESS
build-docker-image✅SUCCESS
compile-nydus✅SUCCESS
compile-ctr-remote✅SUCCESS
compile-nydus-snapshotter✅SUCCESS
start-nydus-snapshotter-config-containerd✅SUCCESS
run-container-with-nydus-image✅SUCCESS

Congratulations, your test job passed!

…wrong index for v6

At present, the prefetch table of v6 is stored in Node.index, which starts from 1,
and when we get the prefetch table, we mistakenly treat it as an array index

Signed-off-by: zyfjeff <zyfjeff@linux.alibaba.com>
@yqleng1987
Copy link
Contributor

@zyfjeff , your pull request has been updated. A new test job will be submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@zyfjeff , your test job has passed, and no need to test again.

@jiangliu jiangliu merged commit 336985f into dragonflyoss:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants