Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rafs: fix bug in InodeWrapper::is_sock() #1630

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

SToPire
Copy link
Contributor

@SToPire SToPire commented Sep 26, 2024

We incorrectly use is_dir() to check if a file is a socket. This patch fixes it.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

We incorrectly use is_dir() to check if a file is a socket. This patch
fixes it.

Signed-off-by: Yifan Zhao <zhaoyifan@sjtu.edu.cn>
@SToPire SToPire requested a review from a team as a code owner September 26, 2024 15:04
@SToPire SToPire requested review from imeoer, hsiangkao and power-more and removed request for a team September 26, 2024 15:04
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.28%. Comparing base (9f439ab) to head (9dc005d).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1630      +/-   ##
==========================================
- Coverage   61.28%   61.28%   -0.01%     
==========================================
  Files         146      146              
  Lines       48156    48156              
  Branches    46123    46123              
==========================================
- Hits        29514    29510       -4     
- Misses      17084    17085       +1     
- Partials     1558     1561       +3     
Files with missing lines Coverage Δ
rafs/src/metadata/inode.rs 95.39% <100.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imeoer imeoer merged commit a4683ba into dragonflyoss:master Sep 27, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants