Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nydusctl: fix build version info #1625

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

image

Details

keep nydusctl version info same with nydusd and nydusd-image:
image

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high Desiki-high requested a review from a team as a code owner September 20, 2024 08:07
@Desiki-high Desiki-high requested review from bergwolf, jiangliu and gaius-qi and removed request for a team September 20, 2024 08:07
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.27%. Comparing base (742954e) to head (a6b78f5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/bin/nydusctl/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1625      +/-   ##
==========================================
- Coverage   61.28%   61.27%   -0.02%     
==========================================
  Files         146      146              
  Lines       48156    48156              
  Branches    46123    46123              
==========================================
- Hits        29511    29506       -5     
- Misses      17084    17089       +5     
  Partials     1561     1561              
Files with missing lines Coverage Δ
src/bin/nydusctl/main.rs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@imeoer imeoer merged commit 37a7b96 into dragonflyoss:master Sep 20, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants