refactor: fixed the unnecessary mutex lock operation #1616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
This PR is a preliminary proposal, and I welcome friendly discussions on this issue.
Due to
Rc
is neitherSend
orSync
, it cannot be sent between threads safely. Rust cannot send anRc
to another thread, then you have to construct the value on the thread that will use it, or send the value to that thread before wrapping it in anRc
. So rustc's mechanism will not exploit theMutex
's protection.IMHO, for the most part, we should use
Rc<RefCell<T>>
for single thread orArc<Mutex<T>>
for exclusive access (until compiler complain about our code need Send or Sync).Thank you for your time!
Types of changes
What types of changes does your PullRequest introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply.