Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade components version in test env #1585

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

Desiki-high
Copy link
Member

@Desiki-high Desiki-high commented Jun 5, 2024

Relevant Issue (if applicable)

#1569

Details

  1. Upgrade cni to v1.5.0 to fix errror in TestCommit(Not sure, it seems related with cni).
  2. Upgrade nerdctl to v1.7.6.
  3. Upgrade nydus-snapshotter to v0.13.13 and fix path error.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Desiki-high Desiki-high requested a review from a team as a code owner June 5, 2024 08:42
@Desiki-high Desiki-high requested review from adamqqqplay, hsiangkao and power-more and removed request for a team June 5, 2024 08:42
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.52%. Comparing base (34ab06b) to head (2e93563).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1585   +/-   ##
=======================================
  Coverage   61.51%   61.52%           
=======================================
  Files         144      144           
  Lines       46616    46616           
  Branches    44602    44602           
=======================================
+ Hits        28676    28680    +4     
+ Misses      16456    16452    -4     
  Partials     1484     1484           

see 1 file with indirect coverage changes

@Desiki-high Desiki-high force-pushed the chore/upgrade-nerdctl/cni branch 2 times, most recently from 57aecf9 to 5326130 Compare June 5, 2024 12:01
@Desiki-high Desiki-high requested a review from a team as a code owner June 5, 2024 12:01
@Desiki-high Desiki-high requested review from liubin and imeoer and removed request for a team June 5, 2024 12:01
@Desiki-high Desiki-high force-pushed the chore/upgrade-nerdctl/cni branch 4 times, most recently from c725eb9 to 3cbdffd Compare June 5, 2024 12:51
@Desiki-high Desiki-high changed the title chore: upgrade nerdctl and cni version in test env chore: upgrade components version in test env Jun 5, 2024
1. Upgrade cni to v1.5.0 and try to fix error in TestCommit.
2. upgrade nerdctl to v1.7.6.
3. upgrade nydus-snapshotter to v0.13.13 and fix path error.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imeoer imeoer merged commit 79a7015 into dragonflyoss:master Jun 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants