Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nydusify: refactor with http.ErrSchemeMismatch and syscall.ECONNREFUSED #1528

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

N/A

Details

  1. upgrade go 1.21 to bring http.ErrSchemeMismatch, ref:net/http: add ErrSchemeMismatch golang/go#44855.
  2. refactor RetryWithHTTP with http.ErrSchemeMismatch and syscall.ECONNREFUSED.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
ref: golang/go#44855

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
@Desiki-high Desiki-high requested a review from a team as a code owner December 22, 2023 05:22
@Desiki-high Desiki-high requested review from bergwolf, gaius-qi and hsiangkao and removed request for a team December 22, 2023 05:22
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (18ba2ed) 60.89% compared to head (5aa6504) 60.89%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1528      +/-   ##
==========================================
- Coverage   60.89%   60.89%   -0.01%     
==========================================
  Files         141      141              
  Lines       46277    46265      -12     
  Branches    44153    44153              
==========================================
- Hits        28181    28173       -8     
+ Misses      16658    16652       -6     
- Partials     1438     1440       +2     
Files Coverage Δ
contrib/nydusify/pkg/utils/utils.go 34.45% <0.00%> (+2.39%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@imeoer imeoer merged commit 65046b0 into dragonflyoss:master Dec 25, 2023
21 checks passed
@Desiki-high Desiki-high mentioned this pull request Dec 25, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants