Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change go module name and repo url to nydus #1519

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

Desiki-high
Copy link
Member

Relevant Issue (if applicable)

N/A.

Details

Change go module name to dragonflyoss/nydus/**

Notice: Changing the Golang module name may cause some errors. I'm not sure if other projects depend on these pkgs.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Desiki-high Desiki-high requested a review from a team as a code owner December 14, 2023 07:38
@Desiki-high Desiki-high requested review from imeoer, gaius-qi and hsiangkao and removed request for a team December 14, 2023 07:38
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #1519 (8c68b31) into master (d6da88a) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1519   +/-   ##
=======================================
  Coverage   62.71%   62.72%           
=======================================
  Files         129      129           
  Lines       44153    44153           
  Branches    44153    44153           
=======================================
+ Hits        27691    27695    +4     
+ Misses      15091    15087    -4     
  Partials     1371     1371           
Files Coverage Δ
rafs/src/lib.rs 65.45% <ø> (ø)

... and 2 files with indirect coverage changes

@imeoer
Copy link
Collaborator

imeoer commented Dec 15, 2023

@Desiki-high Sorry for the merge order, let's resolve these conflicts first.

@Desiki-high Desiki-high force-pushed the chore/change-name branch 3 times, most recently from c4cafe2 to 27e5e0e Compare December 15, 2023 06:43
@Desiki-high
Copy link
Member Author

@Desiki-high Sorry for the merge order, let's resolve these conflicts first.

Resolved, PTAL. @imeoer

Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

@imeoer imeoer merged commit 0458817 into dragonflyoss:master Dec 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants