Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: update rust-toolchain file to TOML format #1511

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

adamqqqplay
Copy link
Member

Relevant Issue (if applicable)

Dependabot can't parse our rust-toolchain. Because only rust-toolchain files formatted as TOML are supported in Dependabot. And the non-TOML format was deprecated by Rust.

Details

  1. Move rust-toolchain to rust-toolchain.toml
  2. Update the parsing process of rust-toolchain in the test script.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

1. Move rust-toolchain to rust-toolchain.toml
2. Update the parsing process of rust-toolchain in the test script.

Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
@adamqqqplay adamqqqplay requested a review from a team as a code owner December 11, 2023 07:55
@adamqqqplay adamqqqplay requested review from bergwolf, power-more and Desiki-high and removed request for a team December 11, 2023 07:55
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #1511 (7e70a22) into master (d793aee) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1511      +/-   ##
==========================================
- Coverage   62.73%   62.73%   -0.01%     
==========================================
  Files         129      129              
  Lines       44158    44158              
  Branches    44158    44158              
==========================================
- Hits        27703    27702       -1     
  Misses      15088    15088              
- Partials     1367     1368       +1     

see 2 files with indirect coverage changes

@imeoer
Copy link
Collaborator

imeoer commented Dec 11, 2023

Any benefit to using the toml?

@adamqqqplay
Copy link
Member Author

Any benefit to using the toml?

The main reason I submitted this PR was that Github Dependabot was unable to parse our legacy rust toolchain, which did not facilitate quick fixes for security vulnerabilities.

The rust-toolchain file in TOML format has been supported in rustup 1.23.0, bringing some new features. You can refer to: https://blog.rust-lang.org/2020/11/27/Rustup-1.23 .0.html#new-format-for-rust-toolchain

@jiangliu jiangliu merged commit a84400d into dragonflyoss:master Dec 12, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants