Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: upgrade to go 1.20 #1454

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

adamqqqplay
Copy link
Member

Relevant Issue (if applicable)

#1453 CI fails due to lower Go version.

Details

Keep consistent with other components in container ecosystem, for example containerd is using go 1.20.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Keep consistent with other components in container ecosystem,
for example containerd is using go 1.20.

Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
@adamqqqplay adamqqqplay requested review from a team as code owners October 26, 2023 07:34
@adamqqqplay adamqqqplay requested review from bergwolf, liubogithub and hsiangkao and removed request for a team October 26, 2023 07:34
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1454 (a4273dd) into master (3bb124b) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
- Coverage   46.33%   46.32%   -0.02%     
==========================================
  Files         123      123              
  Lines       38905    38905              
  Branches    38905    38905              
==========================================
- Hits        18027    18023       -4     
- Misses      19907    19908       +1     
- Partials      971      974       +3     

see 3 files with indirect coverage changes

Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit 69ddef9 into dragonflyoss:master Oct 27, 2023
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants