enhance error handling with thiserror

[CormickKneey]

Relevant Issue (if applicable)

close issue

Details

use thiserror in ApiError and RafsError. Also some changes in nydusError.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation Update (if none of the other choices apply)

Checklist

• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• make successfully

[adamqqqplay]

Thanks for your contribution!

BTW, you can use "git commit --amend -s" to sign this commit to pass the CI.

[CormickKneey]

It seems that there might be an issue with the aci pipeline. Could u help take a look or let me know if there is anything else I need to do?

[codecov]

Codecov Report

Merging #1447 (c3fc5cf) into master (5c63ba9) will decrease coverage by 0.02%.
Report is 2 commits behind head on master.
The diff coverage is 15.62%.

@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
- Coverage   46.29%   46.27%   -0.02%     
==========================================
  Files         123      123              
  Lines       38872    38869       -3     
  Branches    38872    38869       -3     
==========================================
- Hits        17995    17987       -8     
- Misses      19906    19909       +3     
- Partials      971      973       +2     

Files	Coverage Δ
service/src/lib.rs	78.66% <ø> (+3.02%)	⬆️
rafs/src/fs.rs	18.64% <0.00%> (ø)
rafs/src/lib.rs	64.24% <0.00%> (+2.25%)	⬆️
rafs/src/metadata/mod.rs	52.49% <0.00%> (ø)
utils/src/trace.rs	77.31% <0.00%> (-2.07%)	⬇️
api/src/error.rs	67.74% <33.33%> (ø)
api/src/http.rs	0.00% <0.00%> (ø)
storage/src/backend/registry.rs	32.16% <17.39%> (-0.78%)	⬇️

... and 2 files with indirect coverage changes

[imeoer]

@CormickKneey The codecov CI should be fixed, let's move forward (the failed codecov/patch can be ignored).

[adamqqqplay]

Thanks for your contribution!

[jiangliu]

Please move it to line 15.

[jiangliu]

how about using #[derive(thiserror::Error, Debug)], it's more informative.

[imeoer]

Thanks for the PR! The target of using thiserror & andhow is to remove the api/src/error.rs file.
Any subsequent PRs will be submitted?

[CormickKneey]

Thanks for the PR! The target of using thiserror & andhow is to remove the api/src/error.rs file. Any subsequent PRs will be submitted?

Ah, I didn't notice the macro rules in the api/src/error.rs earlier. But I took a quick look, and I'm not quite ready to smoothly switch those content to thiserror yet. Maybe I'll complete this task in the next time. 👿