-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nydusify can dump metrics created by converter #1272
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1272 +/- ##
==========================================
- Coverage 45.06% 45.05% -0.01%
==========================================
Files 126 126
Lines 37395 37395
Branches 37395 37395
==========================================
- Hits 16852 16850 -2
- Misses 19655 19657 +2
Partials 888 888 |
34ccdfc
to
893d4b3
Compare
@Desiki-high , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/72272 |
The output json like this:
|
893d4b3
to
879a76f
Compare
@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/72281 |
@Desiki-high , The CI test is completed, please check result:
Congratulations, your test job passed! |
@Desiki-high , The CI test is completed, please check result:
Sorry, your test job failed. Please get the details in the link. |
/retest |
@Desiki-high , the test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/72298 |
@Desiki-high , The CI test is completed, please check result:
Congratulations, your test job passed! |
879a76f
to
072e0a0
Compare
@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/72407 |
@Desiki-high , The CI test is completed, please check result:
Congratulations, your test job passed! |
Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
During convert, we can collect the metric: image size and convert time, etc. Nydusify can dump the metric to local file if user needs. Signed-off-by: Yadong Ding <ding_yadong@foxmail.com>
072e0a0
to
841920f
Compare
@Desiki-high , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/72753 |
@Desiki-high , The CI test is completed, please check result:
Congratulations, your test job passed! |
We are introducing a new arg called "output-json" that will allow us to save the metrics generated by convert. This will enable us to successfully implement #1263 through nydusify.
For additional information, please see goharbor/acceleration-service#133.