-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the benchmark test for nydus #1219
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,259 @@ | ||
#!/usr/bin/env python3 | ||
""" | ||
bench.py references the repo[https://github.com/nydusaccelerator/hello-bench]. | ||
""" | ||
import copy | ||
import json | ||
import logging | ||
import os | ||
import posixpath | ||
import subprocess | ||
import sys | ||
import time | ||
import urllib.request | ||
from contextlib import contextmanager | ||
from datetime import datetime | ||
from io import TextIOWrapper | ||
|
||
|
||
def logging_setup(logging_stream=sys.stderr): | ||
root = logging.getLogger() | ||
|
||
if root.hasHandlers(): | ||
return | ||
|
||
verbose = True | ||
|
||
handler = logging.StreamHandler(logging_stream) | ||
|
||
if verbose: | ||
root.setLevel(logging.DEBUG) | ||
handler.setLevel(logging.DEBUG) | ||
else: | ||
root.setLevel(logging.INFO) | ||
handler.setLevel(logging.INFO) | ||
|
||
formatter = logging.Formatter( | ||
"[%(asctime)s] %(levelname)s " | ||
"[%(module)s - %(lineno)s:%(funcName)s] " | ||
"- %(message)s" | ||
) | ||
handler.setFormatter(formatter) | ||
root.addHandler(handler) | ||
|
||
|
||
logging_setup() | ||
|
||
|
||
def run(cmd, wait: bool = True, verbose=True, **kwargs): | ||
|
||
shell = kwargs.pop("shell", False) | ||
if shell: | ||
cmd = " ".join(cmd) | ||
|
||
if verbose: | ||
logging.info(cmd) | ||
else: | ||
logging.debug(cmd) | ||
|
||
popen_obj = subprocess.Popen(cmd, shell=shell, **kwargs) | ||
if wait: | ||
popen_obj.wait() | ||
return popen_obj.returncode, popen_obj | ||
|
||
|
||
def get_current_time(): | ||
return datetime.now() | ||
|
||
|
||
def delta_time(t_end, t_start): | ||
delta = t_end - t_start | ||
return delta.total_seconds(), delta.microseconds | ||
|
||
|
||
@contextmanager | ||
def timer(cmd): | ||
start = get_current_time() | ||
try: | ||
rc = os.system(cmd) | ||
assert rc == 0 | ||
end = get_current_time() | ||
sec, usec = delta_time(end, start) | ||
yield sec + usec / 1e6 | ||
logging.info("%s, Takes time %u.%u seconds", cmd, sec, usec) | ||
finally: | ||
pass | ||
|
||
|
||
class RunArgs: | ||
def __init__( | ||
self, waitURL="" | ||
): | ||
self.waitURL = waitURL | ||
|
||
|
||
class Bench: | ||
def __init__(self, name, category="other"): | ||
self.name = name | ||
self.category = category | ||
|
||
def __str__(self): | ||
return json.dumps(self.__dict__) | ||
|
||
def set_tag(self, tag): | ||
self.name = f"{self.name}:{tag}" | ||
|
||
|
||
class BenchRunner: | ||
CMD_URL_WAIT = { | ||
"wordpress": RunArgs(waitURL="http://localhost:80"), | ||
} | ||
|
||
# complete listing | ||
ALL = dict( | ||
[ | ||
("wordpress", Bench("wordpress", "web-framework")), | ||
] | ||
) | ||
|
||
def __init__( | ||
self, | ||
registry="localhost:5000", | ||
snapshotter="overlayfs", | ||
cleanup=True, | ||
insecure_registry=False, | ||
): | ||
self.registry = registry | ||
if self.registry != "": | ||
self.registry += "/" | ||
|
||
self.snapshotter = snapshotter | ||
self.insecure_registry = insecure_registry | ||
|
||
self.cleanup = cleanup | ||
|
||
def image_ref(self, repo): | ||
return posixpath.join(self.registry, repo) | ||
|
||
def run(self, bench): | ||
repo = image_repo(bench.name) | ||
if repo in BenchRunner.CMD_URL_WAIT: | ||
return self.run_cmd_url_wait( | ||
repo=bench.name, runargs=BenchRunner.CMD_URL_WAIT[repo] | ||
) | ||
else: | ||
print("Unknown bench: " + repo) | ||
sys.exit(1) | ||
|
||
def run_cmd_url_wait(self, repo, runargs): | ||
image_ref = self.image_ref(repo) | ||
container_id = repo.replace(":", "-") | ||
|
||
pull_cmd = self.pull_cmd(image_ref) | ||
print(pull_cmd) | ||
print("Pulling image %s ..." % image_ref) | ||
with timer(pull_cmd) as t: | ||
pull_elapsed = t | ||
|
||
create_cmd = self.create_cmd_url_wait_cmd(image_ref, container_id, runargs) | ||
print(create_cmd) | ||
|
||
print("Creating container for image %s ..." % image_ref) | ||
with timer(create_cmd) as t: | ||
create_elapsed = t | ||
|
||
run_cmd = self.task_start_cmd(container_id, iteration=False) | ||
print(run_cmd) | ||
|
||
print("Running container %s ..." % container_id) | ||
start_run = datetime.now() | ||
|
||
_ = subprocess.Popen(run_cmd, shell=True) | ||
while True: | ||
try: | ||
req = urllib.request.urlopen(runargs.waitURL) | ||
print(req.status) | ||
req.close() | ||
break | ||
except: | ||
time.sleep(0.01) | ||
|
||
end_run = datetime.now() | ||
run_elapsed = datetime.timestamp(end_run) - datetime.timestamp(start_run) | ||
|
||
print("Run time: %f s" % run_elapsed) | ||
|
||
if self.cleanup: | ||
self.clean_up(image_ref, container_id) | ||
|
||
return pull_elapsed, create_elapsed, run_elapsed | ||
|
||
def pull_cmd(self, image_ref): | ||
insecure_flag = "--insecure-registry" if self.insecure_registry else "" | ||
return ( | ||
f"sudo nerdctl --snapshotter {self.snapshotter} pull {insecure_flag} {image_ref}" | ||
) | ||
|
||
def create_cmd_url_wait_cmd(self, image_ref, container_id, runargs): | ||
cmd = f"sudo nerdctl --snapshotter {self.snapshotter} create --net=host " | ||
cmd += f"--name={container_id} {image_ref}" | ||
return cmd | ||
|
||
def task_start_cmd(self, container_id, iteration: bool): | ||
if iteration: | ||
return f"sudo nerdctl --snapshotter {self.snapshotter} start -a {container_id}" | ||
else: | ||
return f"sudo nerdctl --snapshotter {self.snapshotter} start {container_id}" | ||
|
||
def task_kill_cmd(self, container_id): | ||
return f"sudo nerdctl --snapshotter {self.snapshotter} stop {container_id}" | ||
|
||
def clean_up(self, image_ref, container_id): | ||
print("Cleaning up environment for %s ..." % container_id) | ||
cmd = self.task_kill_cmd(container_id) | ||
print(cmd) | ||
rc = os.system(cmd) # sometimes containers already exit. we ignore the failure. | ||
cmd = f"sudo nerdctl --snapshotter {self.snapshotter} rm -f {container_id}" | ||
print(cmd) | ||
rc = os.system(cmd) | ||
assert rc == 0 | ||
cmd = f"sudo nerdctl --snapshotter {self.snapshotter} rmi -f {image_ref}" | ||
print(cmd) | ||
rc = os.system(cmd) | ||
assert rc == 0 | ||
|
||
|
||
def image_repo(ref: str): | ||
return ref.split(":")[0] | ||
|
||
|
||
def image_tag(ref: str) -> str: | ||
try: | ||
return ref.split(":")[1] | ||
except IndexError: | ||
return None | ||
|
||
|
||
def bench_image(local_registry, insecure_local_registry, image, f: TextIOWrapper, snapshotter="overlayfs"): | ||
try: | ||
bench = copy.deepcopy(BenchRunner.ALL[image_repo(image)]) | ||
tag = image_tag(image) | ||
if tag is not None: | ||
bench.set_tag(tag) | ||
except KeyError: | ||
logging.warning("image %s not supported, skip", image) | ||
sys.exit(1) | ||
runner = BenchRunner( | ||
registry=local_registry, | ||
snapshotter=snapshotter, | ||
cleanup=True, | ||
insecure_registry=insecure_local_registry, | ||
) | ||
pull_elapsed, create_elapsed, run_elapsed = runner.run(bench) | ||
total_elapsed = f"{pull_elapsed + create_elapsed + run_elapsed: .6f}" | ||
pull_elapsed = f"{pull_elapsed: .6f}" | ||
create_elapsed = f"{create_elapsed: .6f}" | ||
run_elapsed = f"{run_elapsed: .6f}" | ||
line = f"{bench.name},{pull_elapsed},{create_elapsed},{run_elapsed},{total_elapsed}" | ||
f.writelines(line + "\n") | ||
f.flush() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
#!/usr/bin/env python3 | ||
from argparse import ArgumentParser | ||
|
||
import bench as bench | ||
import convert as cvt | ||
import metrics | ||
import prefetch_list as alg | ||
import util | ||
import yaml | ||
|
||
CONFIG = "config.yml" | ||
PREFETCH_FILE_LIST = "out_list.txt" | ||
|
||
|
||
def main(): | ||
""" | ||
1. read config file to knows the images:tag and registry and if we need convert to nydus image or not | ||
2. we have four modes for benchmark, the first is oci, the second is nydus without prefetch, the third is nydus with prefetch all, the latest is nydus with prefetch file list | ||
""" | ||
parser = ArgumentParser() | ||
parser.add_argument( | ||
"--mode", | ||
choices=["oci", "nydus-no-prefetch", "nydus-all-prefetch", "nydus-filelist-prefetch"], | ||
dest="mode", | ||
type=str, | ||
required=True, | ||
help="The mode of benchmark. Available modes are: oci, nydus-none_prefetch, nydus-all-prefetch, nydus-filelist-prefetch." | ||
) | ||
args = parser.parse_args() | ||
mode = args.mode | ||
|
||
# read config.yml | ||
cfg = {} | ||
with open(CONFIG, 'r', encoding='utf-8') as f: | ||
try: | ||
cfg = yaml.load(stream=f, Loader=yaml.FullLoader) | ||
except Exception as inst: | ||
print('error reading config file') | ||
print(inst) | ||
exit(-1) | ||
# bench | ||
start_bench(cfg, cfg["image"], mode) | ||
util.show_csv(util.image_repo(cfg["image"]) + ".csv") | ||
|
||
|
||
def collect_metrics(cfg: dict, image: str) -> str: | ||
""" | ||
collect metrics | ||
""" | ||
return metrics.collect(cfg["local_registry"], cfg["insecure_local_registry"], util.image_nydus(image)) | ||
|
||
|
||
def start_bench(cfg: dict, image: str, mode: str): | ||
""" | ||
bench oci, nydus without prefetch, nydus with all prefetch, nydus witch prefetch file list | ||
""" | ||
f = open(util.image_repo(image) + ".csv", "w") | ||
csv_headers = "repo,pull_elapsed(s),create_elapsed(s),run_elapsed(s),total_elapsed(s)" | ||
f.writelines(csv_headers + "\n") | ||
f.flush() | ||
if mode == "oci": | ||
util.enable_wondersphaper(cfg["bandwith"]) | ||
bench.bench_image(cfg["local_registry"], cfg["insecure_local_registry"], image, f) | ||
elif mode == "nydus-no-prefetch": | ||
util.enable_wondersphaper(cfg["bandwith"]) | ||
bench.bench_image(cfg["local_registry"], cfg["insecure_local_registry"], util.image_nydus(image), f, "nydus") | ||
elif mode == "nydus-all-prefetch": | ||
# open prefetch enable | ||
util.switch_config_prefetch_enable() | ||
util.reload_nydus() | ||
util.enable_wondersphaper(cfg["bandwith"]) | ||
bench.bench_image(cfg["local_registry"], cfg["insecure_local_registry"], util.image_nydus(image), f, "nydus") | ||
else: | ||
# opne the metrics colletc api | ||
util.switch_config_access_pattern() | ||
util.reload_nydus() | ||
# collect metrics data | ||
file = collect_metrics(cfg, image) | ||
# generate prefetch list | ||
_ = alg.get_prefetch_list(file) | ||
# rebuild | ||
cvt.convert_nydus_prefetch(cfg["source_registry"], cfg["insecure_source_registry"], cfg["local_registry"], cfg["insecure_local_registry"], image, PREFETCH_FILE_LIST) | ||
# open prefetch enable | ||
util.switch_config_prefetch_enable() | ||
# close the metrics colletc api | ||
util.switch_config_access_pattern() | ||
util.reload_nydus() | ||
util.enable_wondersphaper(cfg["bandwith"]) | ||
bench.bench_image(cfg["local_registry"], cfg["insecure_local_registry"], util.image_nydus_prefetch(image), f, "nydus") | ||
|
||
|
||
if __name__ == "__main__": | ||
main() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{ | ||
"cniVersion": "0.4.0", | ||
"name": "bridge", | ||
"type": "bridge", | ||
"bridge": "cni0", | ||
"isGateway": true, | ||
"ipMasq": true, | ||
"ipam": { | ||
"type": "host-local", | ||
"subnet": "10.10.0.0/16", | ||
"routes": [ | ||
{ "dst": "0.0.0.0/0" } | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
source_registry: docker.io | ||
insecure_source_registry: False | ||
local_registry: localhost:5000 | ||
insecure_local_registry: True | ||
bandwith: 81920 | ||
image: wordpress:latest |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
[proxy_plugins] | ||
[proxy_plugins.nydus] | ||
type = "snapshot" | ||
address = "/run/containerd-nydus/containerd-nydus-grpc.sock" | ||
|
||
[plugins.cri] | ||
[plugins.cri.containerd] | ||
snapshotter = "nydus" | ||
disable_snapshot_annotations = false |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to load this info from a file so we can add more similar cases easily?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can do that. Actually in this version, we only benchmark for wordpress. You can see #1220, we will add more images and configs to enhancement this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.