storage: fix http fallback handle #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we attempt to establish a TLS connection with the HTTP registry server, we are likely to encounter these types of error: - Error `wrong version number` from openssl library; - Error `connection refused` from standard library; Before this, only the first type of error was handled. This commit handles the second type of error, which was reproduced by running a local insecure harbor registry. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
imeoer
requested review from
liubin,
luodw and
adamqqqplay
and removed request for
a team
|
@imeoer , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/63089 |
|
@imeoer , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
jiangliu
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we attempt to establish a TLS connection with the HTTP registry server,
we are likely to encounter these types of error:
wrong version numberfrom openssl library;connection refusedfrom standard library;Before this, only the first type of error was handled. This commit handles
the second type of error, which was reproduced by running a local insecure
harbor registry.