Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update helm charts deploy guide #386

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Jun 30, 2021

Description

Update helm charts deploy guide

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner June 30, 2021 10:03
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2021

Codecov Report

Merging #386 (c5947a0) into main (6815a64) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
- Coverage   42.34%   42.25%   -0.09%     
==========================================
  Files          73       73              
  Lines        5640     5640              
==========================================
- Hits         2388     2383       -5     
- Misses       2905     2908       +3     
- Partials      347      349       +2     
Flag Coverage Δ
unittests 42.25% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream_callback.go 62.50% <0.00%> (-2.50%) ⬇️
client/daemon/peer/peertask_stream.go 56.98% <0.00%> (-1.14%) ⬇️

Copy link

@xujihui1985 xujihui1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 6b0ff5d into main Jun 30, 2021
@gaius-qi gaius-qi deleted the feature/update-helm-charts-deploy-guide branch June 30, 2021 10:07
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants