Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support CRC-32-Castagnoli algorithm #3664

Merged
merged 1 commit into from
Nov 26, 2024
Merged

feat: support CRC-32-Castagnoli algorithm #3664

merged 1 commit into from
Nov 26, 2024

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes updates to dependencies and a bug fix to the pkg/digest/digest.go file. The most important changes are:

Dependency updates:

  • go.mod: Updated the d7y.io/api/v2 dependency from version v2.0.173 to v2.0.175.

Bug fixes:

  • pkg/digest/digest.go: Modified the Parse function to handle an additional valid length for the AlgorithmCRC32 encoded string, allowing lengths of 8 and 10.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added the enhancement New feature or request label Nov 25, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Nov 25, 2024
@gaius-qi gaius-qi self-assigned this Nov 25, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner November 25, 2024 14:19
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.41%. Comparing base (386c91b) to head (d843aae).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/digest/digest.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3664      +/-   ##
==========================================
- Coverage   35.42%   35.41%   -0.02%     
==========================================
  Files         335      335              
  Lines       37531    37531              
==========================================
- Hits        13297    13290       -7     
- Misses      23405    23410       +5     
- Partials      829      831       +2     
Flag Coverage Δ
unittests 35.41% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/digest/digest.go 71.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 49f52a0 into main Nov 26, 2024
27 checks passed
@gaius-qi gaius-qi deleted the feature/crc32 branch November 26, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants