Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rate limit for job open api by cluster #3638

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Nov 8, 2024

Description

Related Issue

#3638

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Nov 8, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Nov 8, 2024
@gaius-qi gaius-qi self-assigned this Nov 8, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner November 8, 2024 06:44
Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 102 lines in your changes missing coverage. Please review.

Project coverage is 35.30%. Comparing base (5040c1e) to head (6022b8b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/ratelimiter/job_ratelimiter.go 0.00% 68 Missing ⚠️
manager/manager.go 0.00% 12 Missing ⚠️
internal/ratelimiter/distributed_ratelimiter.go 0.00% 7 Missing ⚠️
manager/middlewares/ratelimiter.go 0.00% 7 Missing ⚠️
pkg/redis/redis.go 0.00% 4 Missing ⚠️
manager/router/router.go 0.00% 3 Missing ⚠️
manager/database/database.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3638      +/-   ##
==========================================
- Coverage   35.45%   35.30%   -0.15%     
==========================================
  Files         335      337       +2     
  Lines       37572    37652      +80     
==========================================
- Hits        13320    13294      -26     
- Misses      23413    23517     +104     
- Partials      839      841       +2     
Flag Coverage Δ
unittests 35.30% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/config/config.go 96.28% <ø> (-0.21%) ⬇️
manager/database/database.go 0.00% <0.00%> (ø)
manager/router/router.go 0.00% <0.00%> (ø)
pkg/redis/redis.go 36.66% <0.00%> (-2.62%) ⬇️
internal/ratelimiter/distributed_ratelimiter.go 0.00% <0.00%> (ø)
manager/middlewares/ratelimiter.go 0.00% <0.00%> (ø)
manager/manager.go 0.00% <0.00%> (ø)
internal/ratelimiter/job_ratelimiter.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@gaius-qi gaius-qi merged commit b31e5be into main Nov 8, 2024
27 checks passed
@gaius-qi gaius-qi deleted the feature/ratelimit branch November 8, 2024 07:18
@gaius-qi gaius-qi linked an issue Nov 8, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manager adds ratelimit for CreateJob and GetJobs.
2 participants