Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: if seed peer download task, return NeedBackToSource directly #2980

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added enhancement New feature or request scheduler labels Dec 26, 2023
@gaius-qi gaius-qi added this to the v2.2.0 milestone Dec 26, 2023
@gaius-qi gaius-qi self-assigned this Dec 26, 2023
@gaius-qi gaius-qi requested a review from a team as a code owner December 26, 2023 10:33
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5989a4d) 51.10% compared to head (75ea1ff) 51.08%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2980      +/-   ##
==========================================
- Coverage   51.10%   51.08%   -0.02%     
==========================================
  Files         161      161              
  Lines       21894    21894              
==========================================
- Hits        11189    11185       -4     
- Misses      10045    10047       +2     
- Partials      660      662       +2     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 51.08% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
scheduler/service/service_v2.go 84.85% <100.00%> (ø)

... and 2 files with indirect coverage changes

@gaius-qi gaius-qi merged commit 086cb62 into main Dec 26, 2023
21 checks passed
@gaius-qi gaius-qi deleted the feature/seed-peer branch December 26, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants