Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update resource director #2243

Merged
merged 4 commits into from
Apr 7, 2023
Merged

feat: update resource director #2243

merged 4 commits into from
Apr 7, 2023

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Apr 4, 2023

Description

  1. Rename AuthInfoInject to Director
  2. Update oras resource logic

Related Issue

Fix #2215

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Jim Ma <majinjing3@gmail.com>
@jim3ma jim3ma requested a review from a team as a code owner April 4, 2023 08:02
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #2243 (b749155) into main (d955b1b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2243      +/-   ##
==========================================
- Coverage   49.61%   49.61%   -0.01%     
==========================================
  Files         146      146              
  Lines       19505    19510       +5     
==========================================
+ Hits         9677     9679       +2     
- Misses       9230     9233       +3     
  Partials      598      598              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 49.61% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/dfget/dfget.go 9.19% <0.00%> (-0.11%) ⬇️
pkg/source/source_client_builder.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

jim3ma added 3 commits April 4, 2023 18:24
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bigerous bigerous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 5c18272 into main Apr 7, 2023
@jim3ma jim3ma deleted the feat/resource-director branch April 7, 2023 14:14
lilongfeng0902 pushed a commit to lilongfeng0902/Dragonfly2 that referenced this pull request May 15, 2023
* feat: update resource director
* chore: add digest check for oras

Signed-off-by: Jim Ma <majinjing3@gmail.com>
Signed-off-by: 李龙峰 <lilongfeng@inspur.com>
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* feat: update resource director
* chore: add digest check for oras

Signed-off-by: Jim Ma <majinjing3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SHA256 checksum check for Oras resource client downloads.
3 participants