Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: scheduler grpc #1310

Merged
merged 2 commits into from
May 18, 2022
Merged

refactor: scheduler grpc #1310

merged 2 commits into from
May 18, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius gaius.qi@gmail.com

Description

  • Refactor scheduler grpc.
  • Fix otelgrpc goroutine leak.
  • Fix dfdaemon GetExtendAttribute request.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi
refactor: scheduler grpc
99bc7cf 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.0.3 milestone May 17, 2022
@gaius-qi gaius-qi self-assigned this May 17, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner May 17, 2022 14:07
@gaius-qi gaius-qi requested a review from a team as a code owner May 17, 2022 14:10
@gaius-qi gaius-qi force-pushed the feature/scheduler-grpc branch 3 times, most recently from b02dbe1 to a86913d Compare May 17, 2022 14:46
@gaius-qi
feat: generate protoc
fb2c43f 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi force-pushed the feature/scheduler-grpc branch from a86913d to fb2c43f Compare May 17, 2022 15:02
hyy0322
hyy0322 approved these changes May 18, 2022
View reviewed changes
Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cndoit18
cndoit18 approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 7610d47 into main May 18, 2022
@gaius-qi gaius-qi deleted the feature/scheduler-grpc branch May 18, 2022 03:10
@gaius-qi gaius-qi linked an issue May 18, 2022 that may be closed by this pull request
GRPC stream goroutine leak #1206
Closed
gaius-qi added a commit that referenced this pull request Jun 28, 2023
@gaius-qi
refactor: scheduler grpc (#1310)
2a0314e 
* refactor: scheduler grpc

Signed-off-by: Gaius <gaius.qi@gmail.com>

* feat: generate protoc

Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cndoit18 cndoit18 cndoit18 approved these changes

@hyy0322 hyy0322 hyy0322 approved these changes

@1037husterljx 1037husterljx Awaiting requested review from 1037husterljx 1037husterljx is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@caitongxin caitongxin Awaiting requested review from caitongxin caitongxin is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@zzy987 zzy987 Awaiting requested review from zzy987 zzy987 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@yxxhero yxxhero Awaiting requested review from yxxhero yxxhero is a code owner automatically assigned from dragonflyoss/dragonfly2-maintainers

@yangjun289519474 yangjun289519474 Awaiting requested review from yangjun289519474 yangjun289519474 is a code owner automatically assigned from dragonflyoss/dragonfly2-maintainers

Assignees

@gaius-qi gaius-qi

Labels
client manager scheduler
Projects
None yet
Milestone
v2.0.3
Development

Successfully merging this pull request may close these issues.

GRPC stream goroutine leak
3 participants
@gaius-qi @hyy0322 @cndoit18