Support Cluster configuration for dfly_bench #4664
Conversation
The load tester client opens a connection to each shard, in total `num_shards * FLAGS_c * FLAGS_proactor_threads` connections. There is no support for MOVED responses at the moment so only static clusters are supported. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
force-pushed
the
BenchCluster
branch
from
6770aa0 to
b29f3f1
Compare
There was a problem hiding this comment.
I do have some faith that the function FetchCluster does the right thing. I can thoroughly review it but I will need to pull the branch locally and play around -- I am not familiar with dfly_bench that much.
I would also like to see dfly_bench tests. Maybe it's an overkill though 🤷
Lastly, happy to pull your branch and play around if you want me to. I did not because dfly_bench is not "core".
| @@ -724,6 +802,82 @@ void WatchFiber(atomic_bool* finish_signal, ProactorPool* pp) { | |||
| } | |||
| } | |||
|
|
|||
| ClusterSpec FetchCluster(const tcp::endpoint& ep, ProactorBase* proactor) { | |||
There was a problem hiding this comment.
I went over this function briefly but I did not do a thorough review so I can't really guarantee the correctness of it. Moreover, for changes like this it's nice to have tests. And speaking of that do we have tests for dfly_bench ?
There was a problem hiding this comment.
we do not - it's not part of a production stack
The load tester client opens a connection to each shard, in total
num_shards * FLAGS_c * FLAGS_proactor_threadsconnections.There is no support for MOVED responses at the moment so only static clusters are supported.