Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add slow regression tests #4646

Merged
merged 5 commits into from
Feb 27, 2025
Merged

CI: add slow regression tests #4646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f69bd4
CI: add slow regression tests
adiholden Feb 23, 2025
78f655d
remove filter dbg_only
adiholden Feb 23, 2025
4a55970
and empty filter
adiholden Feb 23, 2025
9520839
fix replication test
adiholden Feb 26, 2025
4cffbb3
add comment
adiholden Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,9 @@ jobs:
dfly-executable: dragonfly
run-only-on-ubuntu-latest: true
build-folder-name: build
filter: ${{ matrix.build-type == 'Release' && '(not slow) and (not dbg_only)' || '(not slow) and (not opt_only)' }}
# Non-release build will not run tests marked as slow or opt_only
# "not empty" string is needed for release build because pytest command can not get empty string for filter
filter: ${{ matrix.build-type == 'Release' && 'not empty' || '(not slow) and (not opt_only)' }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not empty is needed because we can not use empty filter

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course we dont have any empty marker in our code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider leaving a comment for this -- we will forget it in one week from now 🤣


- name: Upload regression logs on failure
if: failure()
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/epoll-regression-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
dfly-executable: dragonfly
gspace-secret: ${{ secrets.GSPACES_BOT_DF_BUILD }}
build-folder-name: build
filter: ${{ matrix.build-type == 'Release' && 'not dbg_only' || 'not opt_only' }}
filter: ${{ matrix.build-type == 'Release' && 'not empty' || 'not opt_only' }}
aws-access-key-id: ${{ secrets.AWS_S3_ACCESS_KEY }}
aws-secret-access-key: ${{ secrets.AWS_S3_ACCESS_SECRET }}
s3-bucket: ${{ secrets.S3_REGTEST_BUCKET }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/regression-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
dfly-executable: dragonfly
gspace-secret: ${{ secrets.GSPACES_BOT_DF_BUILD }}
build-folder-name: build
filter: ${{ matrix.build-type == 'Release' && 'not dbg_only' || 'not opt_only' }}
filter: ${{ matrix.build-type == 'Release' && 'not empty' || 'not opt_only' }}
aws-access-key-id: ${{ secrets.AWS_S3_ACCESS_KEY }}
aws-secret-access-key: ${{ secrets.AWS_S3_ACCESS_SECRET }}
s3-bucket: ${{ secrets.S3_REGTEST_BUCKET }}
Expand Down
2 changes: 1 addition & 1 deletion src/server/replica.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ GenericError Replica::Start() {

auto check_connection_error = [this](error_code ec, const char* msg) -> GenericError {
if (!cntx_.IsRunning()) {
return {std::make_error_code(errc::operation_canceled), "replication cancelled"};
return {"replication cancelled"};
}
if (ec) {
cntx_.ReportCancelError();
Expand Down
Loading