Annotate more caml_stat_* functions
#171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
force-pushed
the
caml_stat_strndup
branch
from
ca2f53f
to
ddf4056
Compare
dra27
force-pushed
the
caml_stat_strndup
branch
from
48cd2d8
to
3a24aa9
Compare
dra27
added
the
no-change-entry-needed
dra27
reviewed
Oct 24, 2024
runtime/caml/osdeps.h
Outdated
| CAMLextern char *caml_stat_char_array_of_utf16(const wchar_t *s, size_t size, | ||
| size_t *out_size); | ||
|
|
||
| /* [caml_copy_string_of_utf16(s)] returns an OCaml string containing a copy of | ||
| [s] re-encoded in UTF-8 if [caml_windows_unicode_runtime_enabled] is non-zero | ||
| or in the current code page otherwise. | ||
| */ | ||
| CAMLalloc(caml_stat_free, 1) CAMLreturns_nonnull() |
There was a problem hiding this comment.
This one simply shouldn't be here, right?
MisterDA
force-pushed
the
caml_stat_strndup
branch
from
3a24aa9
to
b48f01b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
alloc_sizeattributes indicates a size in bytes and cannot be used with a parameter describing the number ofwchar_tin a wide-character buffer.