Skip to content

Commit

Permalink
WIP dllimport for threads.cmxa as well
Browse files Browse the repository at this point in the history
- st_stubs.c removes dllimport for native code in order to have a more
  efficient bridge to the runtime (is this done for primitives as
  well?). That's definitely a strong case for threads.cmxs (because
  it's different)
- ocamlnat always compiles a .cmxs for a #load of a .cmxa/.cmx:
  - For .cmxa it would seem better to load a .cmxs if it exists at the
    same location?
  - Check our META files (and down) - what's ocamlnat support like, and
    should we be listing .cmxs files here?
  • Loading branch information
dra27 committed Sep 29, 2024
1 parent 1cb2e4d commit 27bb7a4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion otherlibs/systhreads/st_stubs.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

#define CAML_INTERNALS

#if defined(_WIN32) && !defined(NATIVE_CODE) && !defined(_MSC_VER)
#if defined(_WIN32) /*&& !defined(NATIVE_CODE)*/ && !defined(_MSC_VER)
/* Ensure that pthread.h marks symbols __declspec(dllimport) so that they can be
picked up from the runtime (which will have linked winpthreads statically).
mingw-w64 11.0.0 introduced WINPTHREADS_USE_DLLIMPORT to do this explicitly;
Expand Down

0 comments on commit 27bb7a4

Please sign in to comment.