Merged PR 2480: 11184 setting directories correctly when user is jumn…

…ping between tabs setting directories correctly when user is jumnping between tabs
dqops · Mar 3, 2024 · 1607b55 · 1607b55
2 parents 12ee226 + f3561db
commit 1607b55
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 10 deletions.
diff --git a/.../src/main/frontend/src/components/Dashboard/DatabaseConnection/DuckDBConnection/index.tsx b/.../src/main/frontend/src/components/Dashboard/DatabaseConnection/DuckDBConnection/index.tsx
@@ -71,7 +71,7 @@ const DuckdbConnection = ({
     {
       label: 'AWS S3',
       value: DuckdbParametersSpecSecretsTypeEnum.s3
-    },
+    }
     // todo: uncomment below when implemented
     // {
     //   label: 'Google Cloud Storage',
@@ -89,16 +89,17 @@ const DuckdbConnection = ({
 
   return (
     <SectionWrapper title="DuckDB connection parameters" className="mb-4">
-
       <Select
-          label="Storage type"
-          options={secretsTypeOptions}
-          className="mb-4"
-          value={ duckdb?.secrets_type }
-          onChange={(value) => { handleChange({ secrets_type: value })}}
-        />
+        label="Storage type"
+        options={secretsTypeOptions}
+        className="mb-4"
+        value={duckdb?.secrets_type}
+        onChange={(value) => {
+          handleChange({ secrets_type: value });
+        }}
+      />
 
-      { duckdb?.secrets_type === DuckdbParametersSpecSecretsTypeEnum.s3 &&
+      {duckdb?.secrets_type === DuckdbParametersSpecSecretsTypeEnum.s3 && (
         <>
           <FieldTypeInput
             data={sharedCredentials}
@@ -124,7 +125,7 @@ const DuckdbConnection = ({
             onChange={(value) => handleChange({ region: value })}
           />
         </>
-      }
+      )}
 
       <FileFormatConfiguration
         fileFormatType={fileFormatType}

diff --git a/dqops/src/main/frontend/src/components/FileFormatConfiguration/KeyValueProperties/index.tsx b/dqops/src/main/frontend/src/components/FileFormatConfiguration/KeyValueProperties/index.tsx
@@ -55,6 +55,14 @@ const KeyValueProperties = ({
     }
   }, [arr]);
 
+  useEffect(() => {
+    if (properties) {
+      setArr(convertObjectToArray(properties ?? {}));
+    } else {
+      setArr([{ ['']: '' }]);
+    }
+  }, [properties]);
+
   return (
     <div className="py-4">
       <table className="my-3 w-full">