Allow disabling thread wakeup in send_request_to_node #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Closing this PR since it's unlikely to be reviewed due to #2290 |
|
Sorry, I missed this previously. I'm 👍 on this, and since it's in the admin client it's not too intrusive into core. I heavily refactored a ton of the admin client and the datadog check, so I am pretty comfortable with this section of code. If you re-open/rebase I can merge. That said, I probably won't be cutting a release since that's up to @dpkp but at least you can land on master and then pin to a sha upstream in datadog. |
|
@jeffwidman sounds good, I'll reopen the PR! |
jeffwidman
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Flying blind due to #2356, but this looks like a pretty low-risk change.
hiwakaba
pushed a commit
to hiwakaba/kafka-python
that referenced
this pull request
Jul 13, 2023
hiwakaba
pushed a commit
to hiwakaba/kafka-python
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Datadog kafka_consumer check uses the
kafka-pythonclient library to collect metrics. On very large clusters, it sometimes gets aKafkaTimeoutErrorsimilar to the one here. We've been able to work around this by disabling the socket wakeup since our check runs in a single thread (after looking at this old Github issue that was meant to fix the issue). However, we needed to re-implement some parts of the_send_request_to_node()function since the library's version always runs a socket wakeup.This PR just adds the
wakeupargument to_send_request_to_node()to make it easier to skip socket wakeup.I saw that there's a few other places in the code that calls
_client.send()where adding awakeupargument can be possible (examples: 1, 2), but wasn't sure if those would necessarily be useful.Let me know if I should do anything else for this PR!
This change is