-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SSL connection testing in Python 3.7 #1669
Conversation
This is based on @seanthegeek's pull request 1661 but cleaned up a bit (just one commit to one specific file) I'm not sure why it's still showing the integration test as "pending" when it actually completed successfully if you click through at https://travis-ci.org/dpkp/kafka-python/builds/464615729?utm_source=github_status&utm_medium=notification This closes #1549 |
What is stalling this? Support for 3.7 would be super nice! |
@dpkp happy new year! is it possible to merge this so we can run on python 3.7? |
Thanks @silentben / @seanthegeek! Merging now. |
Thanks! Was it released to PyPi? |
I'm asking as I keep getting this error locally :) |
I'd be happy if you can release that so I take my project back to 3.7 :) Thanks! |
We have been unable to get travis trsts to run on py37. Can you help us
figure that out?
…On Mon, Jan 14, 2019, 2:40 PM Almog Cohen ***@***.*** wrote:
I'd be happy if you can release that so I take my project back to 3.7 :)
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1669 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAzetBmpDHyN1qn-EiB8DCFkj1dMVMSzks5vDQdfgaJpZM4ZHN3n>
.
|
I can take a look. I got a bit confused in the repo as I thought it was already merged. Where would I find the latest work that includes the 3.7 fix and failed travis build? some branch? |
Open PR is at #1614
…On Mon, Jan 14, 2019, 3:34 PM Almog Cohen ***@***.*** wrote:
I can take a look. I got a bit confused in the repo as I thought it was
already merged. Where would I find the latest work that includes the 3.7
fix and failed travis build? some branch?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1669 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAzetJLLe5j-6HpHaI4FHmr1q1Ry2x0-ks5vDRP2gaJpZM4ZHN3n>
.
|
This change is