Fix lack of timeout support in KafkaClient and KafkaConnection #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I spotted this in #158 and fixed it there as well. I didn't want to write a special test for the connect method so I just refactored it away in favor of the correct one. |
|
Sure, I saw that, looks good --- but I don't think you fixed the fact that self._sock.connect((self.host, self.port))
self._sock.settimeout(self.timeout) |
wizzat
added a commit
to wizzat/kafka-python
that referenced
this pull request
Apr 19, 2014
|
Oh, you are totally correct. I pulled that in and wrote a test for it so that it doesn't get broken in the future. |
|
Sounds good. When do you think you will merge into master? |
dpkp
added a commit
that referenced
this pull request
May 6, 2014
Fix connection timeout in KafkaClient and KafkaConnection
wbarnha
added a commit
to orange-kao/kafka-python
that referenced
this pull request
Mar 9, 2024
* Test Kafka 0.8.2.2 using Python 3.11 in the meantime * Override PYTHON_LATEST conditionally in python-package.yml * Update python-package.yml * add python annotation to kafka version test matrix * Update python-package.yml * try python 3.10
bradenneal1
pushed a commit
to bradenneal1/kafka-python
that referenced
this pull request
May 16, 2024
* Test Kafka 0.8.2.2 using Python 3.11 in the meantime * Override PYTHON_LATEST conditionally in python-package.yml * Update python-package.yml * add python annotation to kafka version test matrix * Update python-package.yml * try python 3.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeout was not passed correctly from
KafkaClienttoKafkaConnection--- and then was not actually applied to the socket inKafkaConnectionitself.To test this, try
KafkaClient('1.2.3.4:1234', timeout=0.1)--- this hangs for a long time in master (as doesKafkaConnection('1.2.3.4', 1234, 0.1).This is a critical issue in production systems.