feat: add opt-in outer default load option to model REST API #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1971 +/- ##
=======================================
Coverage 78.12% 78.13%
=======================================
Files 71 71
Lines 8609 8612 +3
=======================================
+ Hits 6726 6729 +3
Misses 1883 1883
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dpgaspar
commented
Dec 22, 2022
| if getattr(item, file_col): | ||
| fm = FileManager() | ||
| fm.delete_file(getattr(item, file_col)) | ||
| if self.is_file(file_col) and getattr(item, file_col): |
dpgaspar
commented
Dec 22, 2022
| if not getattr(default, "is_scalar", True): | ||
| return None | ||
| return value | ||
| if default is None: |
dpgaspar
commented
Dec 22, 2022
| if (not self.is_pk(col_name)) and (not self.is_fk(col_name)): | ||
| ret_lst.append(col_name) | ||
| return ret_lst | ||
| return [ |
There was a problem hiding this comment.
use a list comprehension
dpgaspar
commented
Dec 22, 2022
| ) -> Query: | ||
| if not select_columns: | ||
| return query | ||
|
|
There was a problem hiding this comment.
took the chance to improve readability also
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the default load on outer joins, which was added in this PR: #1961, an opt-in feature that can be enabled or disabled independently for get list and get item endpoints on
ModelRestApi.new attrs on
ModelRestApi:show_outer_default_load = Falselist_outer_default_load = FalseThese will control the type of outer joins that are performed, by default nothing changes, but setting these to True will make the outer joins default to lazy loading or whatever is defined on the model relation:
https://docs.sqlalchemy.org/en/14/orm/loading_relationships.html#sqlalchemy.orm.defaultload
ADDITIONAL INFORMATION