Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FAB_INDEX_VIEW type check #1883

Merged
merged 6 commits into from
Jul 5, 2022
Merged

fix: FAB_INDEX_VIEW type check #1883

merged 6 commits into from
Jul 5, 2022

Conversation

dpgaspar
Copy link
Owner

@dpgaspar dpgaspar commented Jul 5, 2022

Description

fixes FAB_INDEX_VIEW that was failing with

Traceback (most recent call last):
  File "/app/superset/app.py", line 37, in create_app
    app_initializer.init_app()
  File "/app/superset/initialization/__init__.py", line 460, in init_app
    self.init_app_in_ctx()
  File "/app/superset/initialization/__init__.py", line 408, in init_app_in_ctx
    self.configure_fab()
  File "/app/superset/initialization/__init__.py", line 500, in configure_fab
    appbuilder.init_app(self.superset_app, db.session)
  File "/usr/local/lib/python3.8/site-packages/flask_appbuilder/base.py", line 177, in init_app
    if isinstance(view, BaseView):
NameError: name 'BaseView' is not defined

Also fixes type annotations on AppBuilder

ADDITIONAL INFORMATION

  • Has associated issue:
  • Is CRUD MVC related.
  • Is Auth, RBAC security related.
  • Changes the security db schema.
  • Introduces new feature
  • Removes existing feature

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #1883 (57cb59b) into master (449afe4) will decrease coverage by 0.27%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##           master    #1883      +/-   ##
==========================================
- Coverage   77.64%   77.37%   -0.28%     
==========================================
  Files          70       70              
  Lines        8559     8420     -139     
==========================================
- Hits         6646     6515     -131     
+ Misses       1913     1905       -8     
Flag Coverage Δ
python 77.37% <86.66%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask_appbuilder/base.py 78.85% <86.66%> (+0.79%) ⬆️
flask_appbuilder/models/mixins.py 69.23% <0.00%> (-4.11%) ⬇️
flask_appbuilder/cli.py 55.98% <0.00%> (-2.95%) ⬇️
flask_appbuilder/views.py 63.85% <0.00%> (-2.26%) ⬇️
flask_appbuilder/filters.py 89.79% <0.00%> (-1.20%) ⬇️
flask_appbuilder/security/manager.py 74.45% <0.00%> (-0.68%) ⬇️
flask_appbuilder/babel/views.py 92.30% <0.00%> (-0.55%) ⬇️
flask_appbuilder/security/registerviews.py 31.38% <0.00%> (-0.50%) ⬇️
flask_appbuilder/models/group.py 72.31% <0.00%> (-0.47%) ⬇️
flask_appbuilder/api/manager.py 92.00% <0.00%> (-0.46%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 449afe4...57cb59b. Read the comment docs.

@dpgaspar dpgaspar merged commit cc8e359 into master Jul 5, 2022
@dpgaspar dpgaspar deleted the fix/fab_index_view branch July 5, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant