Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1565] Prevent hanging icon in header journey links #888

Merged
merged 1 commit into from
Oct 15, 2023
Merged

[R20-1565] Prevent hanging icon in header journey links #888

merged 1 commit into from
Oct 15, 2023

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/R20-1565

What I did

  • Add negative offset to prevent hanging icon
  • Update storybook to use current (faulty) production data

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday self-assigned this Oct 6, 2023
@netlify
Copy link

netlify bot commented Oct 6, 2023 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit f31659f
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/651faf92961de200081a3d53

@cypress
Copy link

cypress bot commented Oct 6, 2023

Passing run #784 ↗︎

0 99 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-ui-core): 💄 prevent hanging icon
Project: ripple-framework Commit: f31659fe23
Status: Passed Duration: 04:50 💡
Started: Oct 6, 2023 6:56 AM Ended: Oct 6, 2023 7:01 AM

Review all test suite changes for PR #888 ↗︎

@dylankelly dylankelly enabled auto-merge October 9, 2023 22:55
@dylankelly dylankelly disabled auto-merge October 15, 2023 23:09
@dylankelly dylankelly merged commit 704b024 into develop Oct 15, 2023
@dylankelly dylankelly deleted the fix/r20-1565-hanging-icon branch October 15, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@waitingallday waitingallday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waitingallday @dylankelly