Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1568] added proper publication header mapping #884

Merged
merged 1 commit into from
Oct 6, 2023
Merged

[R20-1568] added proper publication header mapping #884

merged 1 commit into from
Oct 6, 2023

Conversation

jeffdowdle
Copy link
Contributor

…er mapping

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle requested a review from dylankelly October 6, 2023 01:56
@jeffdowdle jeffdowdle self-assigned this Oct 6, 2023
@cypress
Copy link

cypress bot commented Oct 6, 2023

Passing run #773 ↗︎

0 99 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-tide-publication): added proper publication header mapping
Project: ripple-framework Commit: aa657deb71
Status: Passed Duration: 04:53 💡
Started: Oct 6, 2023 1:58 AM Ended: Oct 6, 2023 2:03 AM

Review all test suite changes for PR #884 ↗︎

@dylankelly dylankelly merged commit ea645de into release/2.3.4 Oct 6, 2023
@dylankelly dylankelly changed the title feat(@dpc-sdp/ripple-tide-publication): added proper publication head… [R20-1568] added proper publication header mapping Oct 6, 2023
@waitingallday waitingallday deleted the bugfix/R20-1568-patch branch October 25, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffdowdle @waitingallday @dylankelly