Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1572] Enable external redirects #882

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/R20-1572

What I did

  • Enable external redirects conditionally on redirect_type

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday self-assigned this Oct 6, 2023
@cypress
Copy link

cypress bot commented Oct 6, 2023

Passing run #771 ↗︎

0 99 0 0 Flakiness 0

Details:

fix(nuxt-ripple): 🐛 enable external redirects
Project: ripple-framework Commit: 6c0e489498
Status: Passed Duration: 04:52 💡
Started: Oct 6, 2023 1:48 AM Ended: Oct 6, 2023 1:53 AM

Review all test suite changes for PR #882 ↗︎

@dylankelly dylankelly merged commit acf7d01 into release/2.3.4 Oct 6, 2023
@waitingallday waitingallday deleted the fix/r20-1572-allow-external-redirect branch October 25, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants