Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1533] Custom heading font #871

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

jeffdowdle
Copy link
Contributor

Issue: R20-1533

What I did

  • Adds a CSS variable --rpl-type-font-family-heading to heading typography classes
  • Falls back to the regular font

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 5dbd704
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6514dbaae426040008f1b9ca

@cypress
Copy link

cypress bot commented Sep 28, 2023

Passing run #743 ↗︎

0 99 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-ui-core): added css var for heading font
Project: ripple-framework Commit: 5dbd7044cc
Status: Passed Duration: 05:11 💡
Started: Sep 28, 2023 1:50 AM Ended: Sep 28, 2023 1:56 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@dylankelly dylankelly added this pull request to the merge queue Oct 2, 2023
Merged via the queue into develop with commit e33ddd4 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants